indexer: Push image saved from built container#13441
Conversation
|
/gcbrun trial_build.py expat --fuzzing-engines libfuzzer --sanitizers indexer |
1 similar comment
|
/gcbrun trial_build.py expat --fuzzing-engines libfuzzer --sanitizers indexer |
|
@jonathanmetzman this duplicates with the pushing you added recently, so I removed it for now. WDYT? |
|
|
||
|
|
||
| def _indexer_built_image_name(name: str): | ||
| return f'us-central1-docker.pkg.dev/oss-fuzz/indexer/{name}' |
There was a problem hiding this comment.
hmm.. I wonder if we can use docker image save and docker image load to upload a tar to GCS (using signed URLs) instead of pushing, which comes with the pre-existing problems.
Need to confirm that this works as expected though and saves env vars + entrypoints.
There was a problem hiding this comment.
I've thought of this approach as well. I would bet it works but has some slightly worse performance in downloading and uploading.
I think it would be a good idea to make a cloud function that triggers on write to the bucket that can upload it to the right docker registry. This way the images can be used as normal.
There was a problem hiding this comment.
Nice idea! I've added a TODO here.
It seems fine as use of the images has been deprioritized for now. But I wonder if this technique is inferior for reproducing historical bugs? My (slight) preference is to do both. |
|
TODO for myself:
|
oliverchang
requested review from
DonggeLiu
and removed request for
jonathanmetzman
|
/gcbrun trial_build.py expat skcms --fuzzing-engines libfuzzer --sanitizers indexer |
|
/gcbrun trial_build.py c c++ --fuzzing-engines libfuzzer --sanitizers indexer |
oliverchang
force-pushed
the
save-indexer-image
branch
from
27a7c8f to
2637e83
Compare
|
/gcbrun trial_build.py c c++ --fuzzing-engines libfuzzer --sanitizers indexer |
2 participants
No description provided.